Refactor getInlineExpression #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
force-pushed
the
getInlineExpression
branch
from
add76c2 to
bcdf6ef
Compare
stasm
force-pushed
the
getInlineExpression
branch
from
bcdf6ef to
a4dcbea
Compare
stasm
commented
Dec 4, 2018
|
|
||
| if (ps.currentChar === "-") { | ||
|
|
||
| if (ps.peek() !== ">") { |
Contributor
Author
There was a problem hiding this comment.
We should be more strict in checking the -> syntax here. I'll fix this as part of a future refactor to reduce the use of peek() and next().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #315 (to an extent). I didn't want to add spans manually, so I still kept
getSimpleExpressionas a separate method. (Simple as opposed to member expression; I'm open to other naming.) I think that once we implement projectfluent/fluent#221, we'll be able to simplify this further.I'll clean up the commit messages before landing.